Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-chalk): [menu] the popup menu has 2px border at the bottom #13695

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

tolking
Copy link
Member

@tolking tolking commented Jul 22, 2023

2023-07-22 10.47.26.png

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 14f7d15

Improved menu component styling in menu.scss. Fixed a border-bottom bug and removed unnecessary hover and focus effects for horizontal menu items.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 14f7d15

  • Fix border-bottom bug on horizontal submenus by moving style to more specific selector (link)
  • Remove hover and focus styles from menu items to match design spec and avoid overlap with active style (link)

@github-actions
Copy link

github-actions bot commented Jul 22, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jul 22, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=13695
Please comment the example via this playground if needed.

@btea btea merged commit a434afd into dev Jul 22, 2023
13 checks passed
@btea btea deleted the style/menu-popper-border branch July 22, 2023 11:52
@element-bot element-bot mentioned this pull request Aug 4, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants