Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(components): [switch] add version tag & fix typo #13771

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Conversation

btea
Copy link
Collaborator

@btea btea commented Jul 30, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

rel #13746

🤖 Generated by Copilot at f0f1c2e

Fix typos and update documentation for the Switch component's icon attributes. The changes affect the source code file switch.ts and the documentation file switch.md.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at f0f1c2e

  • Add new attributes active-action-icon and inactive-action-icon to Switch component to customize toggle icons (link, link, link)
  • Update documentation in docs/en-US/component/switch.md to show usage and version number of new attributes (link)
  • Fix typos in attribute descriptions in packages/components/switch/src/switch.ts (link, link)

@github-actions
Copy link

github-actions bot commented Jul 30, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jul 30, 2023
@github-actions
Copy link

github-actions bot commented Jul 30, 2023

🧪 Playground Preview: https://element-plus.run/?pr=13771
Please comment the example via this playground if needed.

@tolking
Copy link
Member

tolking commented Jul 31, 2023

Suggest adding a version number in the demo title as well

custom-action-icon

@btea
Copy link
Collaborator Author

btea commented Jul 31, 2023

@tolking good suggestion 👍

@btea btea merged commit 18c1c77 into dev Jul 31, 2023
10 checks passed
@btea btea deleted the docs/add-version-tag branch July 31, 2023 10:21
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
…3771)

* docs(components): [switch] add version tag & fix typo

* chore: add tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants