feat/template-generator #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `gc.sh` as template generator - Add `gc` as npm script to generate boilerplate
jw-foss
requested review from
HerringtonDarkholme and
iamkun
and removed request for
HerringtonDarkholme and
iamkun
HerringtonDarkholme
requested changes
Jul 22, 2020
scripts/gc.sh
Outdated
| " | ||
| TEMPLATE_PKG_JSON="\n | ||
| {\n | ||
| \"name\": \"eleplus-${NAME}\",\n |
There was a problem hiding this comment.
We probably should use @element-plus/name
scripts/gc.sh
Outdated
| @@ -0,0 +1,65 @@ | |||
| #! /bin/bash | |||
|
|
|||
| export NAME=$1 | |||
There was a problem hiding this comment.
Do we need export here?
jw-foss
commented
Jul 22, 2020
| fi | ||
|
|
||
| DIRNAME="$FILE_PATH/$NAME" | ||
| INPUT_NAME=$NAME |
There was a problem hiding this comment.
@HerringtonDarkholme Added this line here to obtain the original name to fill into the package.json without camel casing the name
HerringtonDarkholme
approved these changes
Jul 22, 2020
Closed
tikazyq
added a commit
to crawlab-team/crawlab-ui
that referenced
this pull request
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gc.shas template generatorgcas npm script to generate boilerplate