fix(components): [input] missing autofocus types #14246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=14246 |
btea
reviewed
Sep 11, 2023
|
The input already has attrs bound to it, I'm not sure if adding an autofocus attribute is necessary. 🤔 |
Yes, it has attrs bound to it, but adding it to the prop is for the type-safe as issue #14243 describes. |
btea
approved these changes
Sep 13, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
* fix(components): [input] missing autofocus types closed element-plus#14243 * fix: autofocus default to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #14243
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 25aecd1
This pull request adds a new
autofocusprop to theElInputcomponent, which enables the native autofocus attribute for the input or textarea element. This prop can be used to automatically focus the input element when the component is rendered. The changes affect the filesinput.vueandinput.tsin thepackages/components/input/srcdirectory.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at 25aecd1
autofocusprop toinputPropsinterface to support native autofocus attribute forElInputcomponent (link)autofocusprop toautofocusattribute of native input element ininput.vuetemplate for single input and textarea cases (link, link)