Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React v16 #200

Closed
wookiem opened this issue May 14, 2017 · 5 comments
Closed

Support for React v16 #200

wookiem opened this issue May 14, 2017 · 5 comments

Comments

@wookiem
Copy link

wookiem commented May 14, 2017

Is there a dev branch that supports React v16 (currently alpha v6)?

Current releases of elemental have a dependency on react-addons-css-transition-group which is deprecated in React v16 in favor of react-transition-group.

The required changes are very minor, but they are breaking changes with React v15:

import CSSTransitionGroup from 'react-transition-group/CSSTransitionGroup' // ES6
var CSSTransitionGroup = require('react-transition-group/CSSTransitionGroup') // ES5 with npm

It looks like impacts only Dropdown.js and Modal.js.

@wookiem wookiem changed the title Support from React v16 Support for React v16 May 17, 2017
@jossmac
Copy link
Member

jossmac commented Sep 9, 2017

@wookiem would love a PR for this 🙂

@jduthon
Copy link
Contributor

jduthon commented Oct 4, 2017

Just did a PR here : #214

Let me know if you see any changes.

I also notice some broken stuff on a bunch of components, will make another PR for those fixes.

@jossmac jossmac closed this as completed in a2d459b Oct 5, 2017
@annarichardson
Copy link

When are the new changes to work with React 16 going to be updated to npm?

@midnightcodr
Copy link

npm still has 0.6.1 as the current version, when will the 0.7.0 version be published to npm?

@moklick
Copy link

moklick commented Jun 8, 2018

Hey, could you please publish the current version to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants