Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "test alerting" on Slack #133

Closed
Maayan-s opened this issue Jul 18, 2022 · 6 comments
Closed

Add "test alerting" on Slack #133

Maayan-s opened this issue Jul 18, 2022 · 6 comments

Comments

@Maayan-s
Copy link
Contributor

Slack alerts are only sent if there are failed tests.
When users deploy Elementary, they want to have a way to validate the deployment worked.
We should have a flag for validating the deployment.

@ronmorgen1
Copy link
Contributor

ronmorgen1 commented Aug 24, 2022

Looks interesting I would be happy to take this. How would you classify a successful deployment?

@Maayan-s
Copy link
Contributor Author

@ronmorgen1

Important background - the CLI has an internal dbt project. This project queries the Elementary tables from the dbt package deployment.
So the flow is:

  1. User installs the dbt package, that collects data to an elementary schema
  2. The CLI has an internal dbt project, with a profile pointing at the elementary schema
  3. The CLI dbt project runs and reads data that should be sent as alerts
  4. The CLI sends alerts to Slack

So a successful deployment means that the elementary schema exists, the CLI can read from it (the profile is well configured), and the CLI can find a Slack config and send a message.

@ronmorgen1
Copy link
Contributor

@Maayan-s

I see. So after the CLI installation when the user runs the command edt monitor, a slack message is sent only when tests fail, and now we want to send one when deployment is successful (?)

@Maayan-s
Copy link
Contributor Author

@ronmorgen1

I think we should probably have a --test flag.
The use case here is that you install but don't have any failed tests at the moment, but you still want to make sure the deployment actually works.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

This issue is stale because it has been open for too long with no activity.
If you would like the issue to remain open, please remove the stale label or leave a comment.

@github-actions github-actions bot added the Stale label Dec 3, 2022
@elongl
Copy link
Member

elongl commented Dec 4, 2022

Added as edr monitor --test.

 --test BOOLEAN                  Whether to send a test message in case there
                                  are no alerts.

@elongl elongl closed this as completed Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants