New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send report to a github page report #373
Comments
Hi @courentin! Thanks for the great suggestion. First off, you can also send your report to Slack or to a GCS bucket if those fit you better. Regarding your request, it seems like it should already be possible to do that.
Afterwards, you should see the report being updated in your website. Here's an untested mock of how the workflow should work. name: Run Elementary report
on:
# Run the action when a push to the main branch of the repository is made.
push:
branches: [ "main", "master" ]
# Run the action when a pull request to the main branch is opened.
pull_request:
branches: [ "main", "master" ]
# Run the action in a scheduled manner every hour.
schedule:
- cron: '0 * * * *'
# Allows you to run this workflow manually from the Actions tab.
workflow_dispatch:
jobs:
elementary:
runs-on: ubuntu-latest
steps:
- name: Run Elementary
uses: elementary-data/run-elementary-action@v1
with:
warehouse-type: snowflake
profiles-yml: ${{ secrets.PROFILES_YML }}
edr-command: edr monitor report --file-path index.html
- name: Commit report
uses: EndBug/add-and-commit@v9.1.0
with:
message: "Updated Elementary's report." How does that sound to you? Thanks a lot! |
Hello @elongl thanks for your answer! Yes I can definitely do use an action for this, that would work perfectly (and it's actually what's I'm doing for the dbt doc). I have not strong opinions on it as above's solution works perfectly fine for me! |
Thanks a lot for this great suggestion, we'll definitely consider that. |
@elongl Maybe we should add this use case to our docs? |
@Maayan-s Sounds like a great idea! @courentin Would you perhaps be interested in adding a section to Elementary's docs regarding how you integrated Elementary's report with GitHub Pages? I think it can be an interesting use-case for a lot of users and it seems like you really nailed this mechanism. Let me know what you think 😄 You can do it by clicking the Edit this page on the Share observability report page. |
I recently noted that there's a very popular action that deploys to GitHub Pages. Maybe worth looking into it and understand the difference. |
Is your feature request related to a problem? Please describe.
Sending reports through S3 is great but by default the s3 website will be publicly accessible. They are way to make it private but they seems pretty complex for a single page website.
Describe the solution you'd like
We could host the report on a github page repository, that would ease access control.
The idea would be to push the html file to a github repository.
The text was updated successfully, but these errors were encountered: