Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELE-1389] Sending Alerts to Different Channels #1010

Closed
lord-skinner opened this issue Jul 19, 2023 · 1 comment
Closed

[ELE-1389] Sending Alerts to Different Channels #1010

lord-skinner opened this issue Jul 19, 2023 · 1 comment

Comments

@lord-skinner
Copy link

lord-skinner commented Jul 19, 2023

Is your feature request related to a problem? Please describe.
Sort of. Currently we are configuring a channel in our models.yml files for alters to go to, but the edr cli requires you as a token/channel and that channel overrides what is in the models.yml. If you pass a webhook, that is associated with a specific channel, again overriding the configured channel in our models.yml file.

Describe the solution you'd like
We'd like for the channel passed into edr to be the default channel, and the channel in the config, if exists, to override it. Pushing alerts with no configured channel to the default channel.

Describe alternatives you've considered
We have used the --select command to send only specifically tagged models to the channel passed into edr, but this is redundent configuration and requires multiple separate jobs/commands to be handle and again disregards the configured channel in our yaml.

Would you be willing to contribute this feature?
Possibly

ELE-1389

@elongl elongl added the linear label Jul 24, 2023
@elongl elongl changed the title Sending Alerts to Different Channels [ELE-1389] Sending Alerts to Different Channels Jul 24, 2023
@elongl elongl removed the linear label Jul 24, 2023
@haritamar
Copy link
Collaborator

Hi @lord-skinner !
Thanks for opening this issue and sorry for the super delayed response.
I believe that this behavior was changed since and we no longer override the channel by default (controlled with the --override-dbt-project-config which is False by default).

If I'm wrong / missing something please feel free to re-open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants