Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic 2.0 Migration #1133

Closed
DustinMoriarty opened this issue Aug 31, 2023 · 3 comments
Closed

Pydantic 2.0 Migration #1133

DustinMoriarty opened this issue Aug 31, 2023 · 3 comments

Comments

@DustinMoriarty
Copy link

DustinMoriarty commented Aug 31, 2023

Is your feature request related to a problem? Please describe.
Pydantic has made major breaking changes with 2.0. They have made a good migration guide. However, migration will require some work. Keeping pydantic at 1.* will prevent other libraries which have migrated to pydantic 2.0 from using elementary. We would like to include elementary as a dependency for one of our projects. However, I don't want to be prevented from upgrading Pydantic and everything else that uses Pydantic.

Describe the solution you'd like
I would like to know if there is a plan for Pydantic 2.0 migration and what the timeline looks like so that we can determine if we should include elementary in our project.

Describe alternatives you've considered
We have considered running Elementary in a separate python environment and calling it with the CLI only. However, this is a pretty messy solution.

Additional context
https://docs.pydantic.dev/latest/migration/

Would you be willing to contribute this feature?
Some as time allows.

@ConstantinoSchillebeeckx

Any progress on this by chance? This is increasingly going to be a deal breaker.

@oliver-tosky-sh
Copy link

Also curious about any updates on this!

I'm seeing two closed/reverted PRs:

and two stale PRs:

Is there a reason why the change was rolled back?

@haritamar
Copy link
Collaborator

Hi all,
Since this issue was last active, we added compatibility support for both pydantic v1 and v2, so either version can be installed without an issue.

Thanks,
Itamar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants