Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on dbt tests link from dashboard redirects to tests page but with source freshness NOT excluded #1524

Open
adamcunnington-mlg opened this issue May 14, 2024 · 2 comments
Labels
Enhancement New feature or request Observability UI Product review Created by Linear-GitHub Sync

Comments

@adamcunnington-mlg
Copy link

Describe the bug
When you click on the numbered links on dashboard screen, they take you to the test execution history, filtered to relevant section. This works as expected most of the time - e.g. if you click here:
image
... you get redirected here:
image

However, when you click on the numbered links below the "dbt tests" section of dashboard, source freshness is NOT excluded in the destination you are redirected to and so you see many more results than the number you clicked on.

Strangely, there is a filter active on the test name column even though everything is selected including source freshness?
image

To Reproduce
Obvious.

Expected behavior
Obvious.

Screenshots
Above

Environment (please complete the following information):

  • edr version: Most recent
  • dbt package Version: 0.14.1

Additional context
Add any other context about the problem here.

@adamcunnington-mlg adamcunnington-mlg added Bug Something isn't working Triage 👀 labels May 14, 2024
@haritamar
Copy link
Collaborator

Hi @adamcunnington-mlg !
Currently this happens because technically "source freshness" belongs to both categories (being a dbt test and also a type of freshness).
That being said, we understand the confusion and it probably makes sense to only include it under the freshness category.

Regarding the filter - it filters on every test originating from dbt. If you had Elementary anomaly tests in your suite, they wouldn't be included in the filter.

@haritamar haritamar added Enhancement New feature or request Observability UI and removed Bug Something isn't working Triage 👀 labels May 15, 2024
@adamcunnington-mlg
Copy link
Author

Thanks for the response. Ok noted on the filter w.r.t excluding anomolies.

But yes, please do filter freshness out here - I think it makes sense and would ensure consistency between dash and the filters - as it is everywhere else.

@haritamar haritamar added the Product review Created by Linear-GitHub Sync label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Observability UI Product review Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants