Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if filter table is found before execution starts #42

Closed
Maayan-s opened this issue Jan 20, 2022 · 0 comments
Closed

Check if filter table is found before execution starts #42

Maayan-s opened this issue Jan 20, 2022 · 0 comments
Labels
Enhancement New feature or request

Comments

@Maayan-s
Copy link
Contributor

When running with a filter, the filtering runs after the graph is calculated.
A check to minimize 'The node is not in the digraph' exception could be added at the beginning of the execution.

Check against information schema:
Pros:

  • Will catch typos and miss-configuration.
  • Fast and easy
    Cons:
  • Will not catch the case where the filtered table exists in the database and schema but not in the queries (time range for example).

Search in the queries:
Pros:

  • Will catch typos, miss-configuration, and table not in selected queries.
    Cons:
  • Might be slow.
@Maayan-s Maayan-s added the Enhancement New feature or request label Jan 20, 2022
@Maayan-s Maayan-s closed this as completed Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant