Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many hard-coded parts #37

Open
ManuelFte opened this issue Sep 20, 2020 · 2 comments
Open

Too many hard-coded parts #37

ManuelFte opened this issue Sep 20, 2020 · 2 comments

Comments

@ManuelFte
Copy link

Prerequisites

  • [ x] I have searched open and closed issues for duplicates.

Describe the bug

The theme's files contain many hard-coded parts, like links and messages, making reference to elementary OS's blog, which makes difficult for other people to use it in their own blogs.

Expected behavior

The theme should make use of variables that can be configured via the _config.yml or the front matters, rather than editing the theme's files directly.

Describe the solution you'd like

I really like this theme and I'd be happy to contribute to it by submitting a PR replacing the hard-coded parts with variables, if you're okay with it.

Platform Information

  • [ x] I'm using the latest version from git that I've manually compiled
  • [x ] I'm using the latest released stable version

I'm using this theme on my self-hosted blog running on an Nginx + Ubuntu 20.04 server.

@cassidyjames
Copy link
Contributor

Yeah, PR(s) welcome to genericize it a bit more.

@ManuelFte
Copy link
Author

ManuelFte commented Sep 20, 2020

Thank you for your disposition. I've already started my work here: https://github.com/ManuelFte/blog-template

I'll hit you up with a PR when I have completed it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants