Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails to compile against mutter 3.35.2+ (removed deprecated ClutterTexture) #659

Closed
decathorpe opened this issue Dec 13, 2019 · 7 comments
Closed
Assignees

Comments

@decathorpe
Copy link

Looking at the NEWS for mutter 3.35.2

* Remove deprecated ClutterTexture [Jonas; !932]

ClutterTexture and ClutterTextureClass were removed.

gala will probably have to be adapted to this change somehow ... at least according to the MR, it looks like alternatives are available:

https://gitlab.gnome.org/GNOME/mutter/merge_requests/932

@worldofpeace
Copy link
Contributor

If it's deprecated it could be easier to implement, i.e no conditional compilation. Because you shouldn't use deprecated code paths, and hopefully the alternate codepaths are viable in older versions of mutter.

@decathorpe
Copy link
Author

If it's deprecated it could be easier to implement, i.e no conditional compilation. Because you shouldn't use deprecated code paths, and hopefully the alternate codepaths are viable in older versions of mutter.

@worldofpeace At least one hopes for that to be the case. On the other hand, I don't take anything for granted when talking about libmutter anymore

@kingodz
Copy link

kingodz commented Feb 9, 2020

Also https://gitlab.gnome.org/GNOME/mutter/merge_requests/458
Some Clutter types were replaced with graphene types:

ClutterGeometry → graphene_rect_t
ClutterPoint → graphene_point_t
ClutterRect → graphene_rect_t
ClutterSize → graphene_size_t
ClutterVertex → graphene_size_t
ClutterVector* → graphene_vec*_t
ClutterVertex → graphene_point3d_t
CoglEuler → graphene_euler_t
CoglQuaternion → graphene_quaternion_t

@kingodz
Copy link

kingodz commented Feb 10, 2020

https://gitlab.gnome.org/GNOME/mutter/merge_requests/935
All the legacy API that deals with the implicit stacks are removed.

@tintou
Copy link
Member

tintou commented Feb 27, 2020

For the people watching this issue, we don't target unreleased versions so no move will be done right now.

@decathorpe
Copy link
Author

@tintou I know, and that's completely understandable.

I originally opened the ticket as a "beware, this change will be coming in a future GNOME release", and looking at the timing of future release dates, it will probably be in ubuntu 20.04 LTS (the base base for the next elementaryOS release?).

And, for better or worse, I've switched all gala and greeter builds on fedora (both official packages and nightly builds) back to using the mutter 3.28 compat package for now ... which might break at any minute, since there's no guarantee that it will keep compiling and working on top of newer GNOME releases ☹️

@tintou
Copy link
Member

tintou commented Mar 12, 2020

Fixed in master

@tintou tintou closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants