Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default-decoration style class constant #395

Closed
cassidyjames opened this issue May 18, 2020 · 2 comments · Fixed by #434
Closed

Add default-decoration style class constant #395

cassidyjames opened this issue May 18, 2020 · 2 comments · Fixed by #434
Labels
Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Needs Design Waiting for input from the UX team Priority: Wishlist Not a bug; but a new feature or enhancement Status: Confirmed Verified by someone other than the reporter

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented May 18, 2020

I thought this might be a GTK thing but it looks like it's not defined by them or us. Since we use it and encourage devs to use it, we should define it as a constant.

@cassidyjames cassidyjames added Priority: Wishlist Not a bug; but a new feature or enhancement Needs Design Waiting for input from the UX team labels May 18, 2020
@danirabbit
Copy link
Member

Yeah Gtk uses it internally, but they don’t have a constant for it.

I kind of feel like it might be better to create a more semantic class name in case Gtk changes this upstream and it breaks all our styles.

@cassidyjames
Copy link
Contributor Author

@danrabbit I don't feel that strongly, but how would it break for apps that are adding the style class via the constant? The nice thing about encouraging using a constant is that we can change it under the hood later if we want to track GTK, or just change it to something else later.

@danirabbit danirabbit added Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Status: Confirmed Verified by someone other than the reporter labels Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Needs Design Waiting for input from the UX team Priority: Wishlist Not a bug; but a new feature or enhancement Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants