Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug appears to be destroyed when navigating away #145

Closed
cassidyjames opened this issue Nov 10, 2020 · 2 comments · Fixed by #149
Closed

Plug appears to be destroyed when navigating away #145

cassidyjames opened this issue Nov 10, 2020 · 2 comments · Fixed by #149

Comments

@cassidyjames
Copy link
Contributor

What Happened

When you hit "All Settings" to leave the About plug, the plug contents themselves seem to disappear. This is made more obvious since elementary/switchboard#181, where it also breaks the animation.

Expected Behavior

Navigating away from the About plug is smooth and matches the other plugs.

Steps to Reproduce

  1. Open the About plug
  2. Hit "All Settings" to leave it

Logs

Platform Information

elementary OS 6 daily, running Switchboard master from Git.

@cassidyjames
Copy link
Contributor Author

This looks suspect, maybe?

public override void hidden () {
main_grid.hide ();
}

@pongloongyeat
Copy link
Member

public override void hidden () {
main_grid.hide ();
}

That does seem to be the issue. Should I open a PR for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants