Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable content grid child switches when service switch is off #43

Closed
wants to merge 4 commits into from
Closed

Disable content grid child switches when service switch is off #43

wants to merge 4 commits into from

Conversation

tjchester
Copy link

@tjchester tjchester commented Oct 3, 2019

Resolves #1 - Change all child switches to off when parent switch is off

@ryonakano
Copy link
Contributor

I think this is intentional. By not changing the state of child switches when the service switch turns off, users can restore their customized sharing setting just by turning on the service switch again.

@tjchester
Copy link
Author

I updated the PR description to include the issue link. If as @ryonakano suggested that we wanted to preserve the user's sharing settings, as an alternative we could just hide the content-grid when the service is disabled.

@ryonakano
Copy link
Contributor

@tjchester Thank you for quoting the issue link! We seem to need some discussion about the design.

@jeremypw
Copy link
Collaborator

@tjchester Closing as has unaddressed issues and no recent activity. Please feel free to reopen (as draft) if you wish to continue working on it.

@jeremypw jeremypw closed this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change all child switches to off while parent switch is off
3 participants