Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-provided color scheme #418

Closed
cassidyjames opened this issue Oct 15, 2019 · 2 comments · Fixed by #662
Closed

User-provided color scheme #418

cassidyjames opened this issue Oct 15, 2019 · 2 comments · Fixed by #662
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice

Comments

@cassidyjames
Copy link
Contributor

We've been getting a handful of PRs to add one-off color schemes, but these are highly subjective and personal. Instead, we've talked about adding a way for a user to set their own color scheme.

@cassidyjames cassidyjames added Priority: Wishlist Not a priority, but something that might be nice Needs Design Waiting for input from the UX team labels Oct 15, 2019
@danirabbit
Copy link
Member

Prior Art

Tilix:
Screenshot from 2019-10-15 10 53 28@2x

Xfce Terminal:
Screenshot from 2019-10-15 11 07 06@2x

GNOME Terminal:
Screenshot from 2019-10-15 11 07 37@2x

@danirabbit
Copy link
Member

danirabbit commented Oct 15, 2019

It doesn't seem like any of the prior art is particularly contextual and it's hard to see how it will relate to the end result. Off the top of my head I feel like a good solution:

  • Doesn't require hunting around in a preferences dialog. We can add a ( + ) add the end of the list of color options in the popover we have currently. This could then throw a dialog that specifically and only manages the stored color schemes.
  • Includes a preview so we can see what the resulting color scheme actually looks like
  • Labels the color selectors (of which it looks like only Tilix tries to do this)
  • If we're really smart, we can do some color contrast checking and warn about color schemes that would be illegible. At the very least we should do this between the background and foreground color and make sure it passes the base A level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants