Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtitle encoding missing from external subtitle #124

Open
cassidyjames opened this issue Feb 25, 2019 · 6 comments
Open

Subtitle encoding missing from external subtitle #124

cassidyjames opened this issue Feb 25, 2019 · 6 comments
Labels
Status: Incomplete Needs more information before we can take action

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented Feb 25, 2019 •
edited by danirabbit
Loading

Moved from https://bugs.launchpad.net/audience/+bug/1360085

raulpetrut:

I have subtitles in Romanian and special characters are shown like this

https://dl.dropboxusercontent.com/u/1383137/Screenshot%20from%202014-08-22%2008%3A57%3A45.png https://dl.dropboxusercontent.com/u/1383137/Screenshot%20from%202014-08-22%2008%3A57%3A48.png

Also you can notice that subtitle looks ugly

This is how it looks in smplayer

https://dl.dropboxusercontent.com/u/1383137/Screenshot%20from%202014-08-22%2009%3A11%3A44.png https://dl.dropboxusercontent.com/u/1383137/Screenshot%20from%202014-08-22%2009%3A12%3A55.png

I wonder if we can take mplayer.conf subtitle settings and integrate it in Audience (subtitle size, shadow, color, language...)

Ivan Vrljić (vrlja92):

Same problem in Croatian. Letters like ž,š etc are shown as 009e or 009e. It is problem with encoding.

image

zin (zdravko-nikolov):

Hi, same problem here with Cyrillic subtitles. There should be an option to change the encoding for external subtitles. This is a must have feature!

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@cassidyjames cassidyjames added the Status: Confirmed Verified by someone other than the reporter label Feb 25, 2019
@arshubham
Copy link
Collaborator

@cassidyjames Seems to be working with #153
Tested with some random Romanian subtitles. and manually adding ž,š character in subs. Can someone confirm with the pr.
image

@ryonakano
Copy link
Contributor

@arshubham Could you share the subtitle and video you've tested?

@arshubham
Copy link
Collaborator

Sub: https://send.firefox.com/download/c88d8ecbae592e8c/#ffa4uEpCB2pBaI_-wzWxwg
You can test it on any video.

@ryonakano
Copy link
Contributor

ryonakano commented Oct 22, 2019 •
edited
Loading

Screenshot from 2019-10-22 22-11-06

@arshubham Thank you. I've also confirmed your PR does fix this issue too.

Edit: wait, the issue seems to be also unreproducible.

@arshubham
Copy link
Collaborator

arshubham commented Oct 22, 2019 •
edited
Loading

I just tested with master, can't reproduce the issue there too. Might have been fixed by gstreamer or subtitles of a particular extensions may be the issue. Adding incomplete status for now if someone has the issue, can share the subtitle file affected.

@arshubham arshubham added Status: Incomplete Needs more information before we can take action and removed Status: Confirmed Verified by someone other than the reporter labels Oct 22, 2019
@nnmlss
Copy link

nnmlss commented Dec 15, 2019 •
edited
Loading

Cyrilic subtitles do not work neighter windows-1251 nor UTF8 encoded.

Screenshot from 2019-12-15 15 06 49
Screenshot from 2019-12-15 15 07 35
subs.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Incomplete Needs more information before we can take action
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cassidyjames @nnmlss @arshubham @ryonakano