Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support smooth scrolling brightness change #58

Closed
matzipan opened this issue Sep 28, 2017 · 2 comments
Closed

Support smooth scrolling brightness change #58

matzipan opened this issue Sep 28, 2017 · 2 comments

Comments

@matzipan
Copy link

matzipan commented Sep 28, 2017

After #57 is closed, the indicator will finally have scroll on the indicator icon. However, neither the icon scroll neither the scroller scroll can handle smooth scrolling gracefully. Currently, #57 increments the brightness 10% for every scroll event, which means a small amount of smooth scroll can lead to a big change.

To support smooth scrolling, the handler needs to check if the event is smooth and then change the brightness value with a value scaled by the delta_y

@matzipan matzipan changed the title Support smooth scrolling value change Support smooth scrolling brightness change Sep 28, 2017
@peteruithoven
Copy link
Collaborator

This should be implemented using a similar approach as the sound indicator, see: handle_scroll.
(since PR: elementary/wingpanel-indicator-sound#81)

@peteruithoven
Copy link
Collaborator

Looks like this is an issue on behavior of a rejected PR, let's close this an put all the scroll related requests in: #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants