Crash when trying to open a channel with amount below fee

[musdom]

crash.log

+514.907417361 lightningd(20657):jcon fd 7:DEBUG: Failing: Amount 1000 below fee 8972
+514.907478519 lightningd(20657):jcon fd 7:DEBUG: Failing: Amount 18446744073709543644 is too large
+514.907638050 lightningd(20657):BROKEN: FATAL SIGNAL 6 RECEIVED```

[rustyrussell]

Adam Mashrique notifications@github.com writes:

crash.log
+514.907179118 lightningd(20657):jcon fd 7:IO-IN: 3738636530353136623434323462383861636364633230663030225d207d +514.907417361 lightningd(20657):jcon fd 7:DEBUG: Failing: Amount 1000 below fee 8972 +514.907478519 lightningd(20657):jcon fd 7:DEBUG: Failing: Amount 18446744073709543644 is too large +514.907638050 lightningd(20657):BROKEN: FATAL SIGNAL 6 RECEIVED

Hi Adam!

    Cool find, thanks!  Obviously, it should fail more gracefully.

I've pushed a fix for now, and audited to make sure it doesn't happen
elsewhere.

Thanks,
Rusty.

[musdom]

I also crashed lightningd trying to open a second channel with the same peer, and it won't start again.

$ ./daemon/lightningd
lightningd(12552): ID: 03a41910dbbcea6d47574e1cbfdce558c5908bb5264af691dc2a89e0ab04a72323
load_peer_anchor_input: two inputs for 'SELECT * FROM anchor_inputs WHERE peer = x'032282512a55842274728d58d371e1186a558071d6de509e32e5d6e765b0d3da7b';'
lightningd(12552): load_peer_anchor_input: two inputs for 'SELECT * FROM anchor_inputs WHERE peer = x'032282512a55842274728d58d371e1186a558071d6de509e32e5d6e765b0d3da7b';'
Log dumped in crash.log

crash.log

+192648.324847682 lightningd(20925):DEBUG: starting: bitcoin-cli -testnet=1 getblock 0000000000001f4116416aa118a3d830133d1d3bfe054381452b7aeeea7be648 false
+192648.347107021 lightningd(20925):DEBUG: reaped 12385: bitcoin-cli -testnet=1 getblock 0000000000001f4116416aa118a3d830133d1d3bfe054381452b7aeeea7be648 false
+192648.347347548 lightningd(20925):DEBUG: Adding block 48e67beaee7a2b45814305fe3b1d3d1330d8a318a16a4116411f000000000000
+192648.347584471 032282512a55842274728d58d371e1186a558071d6de509e32e5d6e765b0d3da7b:DEBUG: Anchor at depth 16
+192648.348025717 lightningd(20925):BROKEN: Amount of 4602 won't cover fee 6400