Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much notification #14

Closed
pegasusearl opened this issue Mar 11, 2022 · 3 comments
Closed

Too much notification #14

pegasusearl opened this issue Mar 11, 2022 · 3 comments

Comments

@pegasusearl
Copy link

This is a video of extreme case:
https://youtu.be/pYR2W7_bsjQ

Sometimes firefox also send some repetitive notifications.

I think a cooldown timer for each app or an options to disable notification entirely would be nice.

I can't manually disable notification as it's not listed in gnome settings > notification.

@elesiuta
Copy link
Owner

Thanks for reporting this, those BPF callbacks not processing fast enough should not be happening, I just released an update that should fix this by increasing the size of the perf ring buffer.

If not I also made it configurable in ~/.config/picosnitch/config.json, try changing it from 64 to 128 or 256 and let me know if that works.

Repetitive notifications should also be improved now, and you shouldn't receive the exact same message multiple times in a row.

Unfortunately there isn't much I can do about things like firefox without also affecting notifications for other programs, since the multiple DNS resolvers that use the firefox executable appear no differently than a number of distinct programs that use the python executable.

If you want to disable notifications, you can set "Desktop notifications" to false in ~/.config/picosnitch/config.json.

I did a quick check to see what's needed to appear in gnome settings and it looks like it might need to use libnotify and gobject instead of dbus, I might give this a try at some point.

@pegasusearl
Copy link
Author

pegasusearl commented Mar 15, 2022

Hello, I'm sorry I can't confirm if the bug is fixed anymore since I have no way of reproducing it.

While I haven't update picosnitch, I tried to run the 'program that cause massive notification issue' again but looks like it does not happen anymore. It only happened when my internet had some strange issue.

Now I already updated picosnitch.

@elesiuta
Copy link
Owner

No worries, thanks for trying and letting me know!

I'll close this issue since I am pretty sure the update will have fixed the root cause of the notifications, or at minimum reduce it to just one notification if it does happen again. Feel free to reopen this issue or create a new one if it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants