New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Sauce Connect and BrowserStack Local are on this image #65

Closed
avcarrillo opened this Issue Mar 18, 2016 · 10 comments

Comments

3 participants
@avcarrillo

avcarrillo commented Mar 18, 2016

Hello,

Can you please provide a little more documentation on how Sauce Connect is used?

Could you also provide some documentation on noVNC?

Thank you

@elgalu

This comment has been minimized.

Show comment
Hide comment
@elgalu

elgalu Mar 18, 2016

Owner

Hi,

Sauce Connect is documented in the README but will be extracted into his own docker image eventually since it doesn't belong here really, same with BrowserStack tunnel.

noVNC support was removed after version 2.52.0g and re-added again later on so can be found on recent versions.

Owner

elgalu commented Mar 18, 2016

Hi,

Sauce Connect is documented in the README but will be extracted into his own docker image eventually since it doesn't belong here really, same with BrowserStack tunnel.

noVNC support was removed after version 2.52.0g and re-added again later on so can be found on recent versions.

@avcarrillo

This comment has been minimized.

Show comment
Hide comment
@avcarrillo

avcarrillo Mar 18, 2016

Hi elgalu,

First of all, great work. My request for documentation is more on the "uses" of sauce connect. The Readme shows the parameters, but not how you would use it with your tests. I have a Sauce Labs account, and would be happy to contribute, but I don't understand what SC does in your image.

When I use SC in my tests I create a RemoteWebDriver Uri which points to ondemand.saucelabs.com. If I use SC in your GRID is it supposed to send jobs to SauceLabs?

Thank you again for the great work

avcarrillo commented Mar 18, 2016

Hi elgalu,

First of all, great work. My request for documentation is more on the "uses" of sauce connect. The Readme shows the parameters, but not how you would use it with your tests. I have a Sauce Labs account, and would be happy to contribute, but I don't understand what SC does in your image.

When I use SC in my tests I create a RemoteWebDriver Uri which points to ondemand.saucelabs.com. If I use SC in your GRID is it supposed to send jobs to SauceLabs?

Thank you again for the great work

@elgalu

This comment has been minimized.

Show comment
Hide comment
@elgalu

elgalu Mar 18, 2016

Owner

First of all, great work.

Thanks :)

If I use SC in your GRID is it supposed to send jobs to SauceLabs

I wish! but no, there is no logic for that, SC will be removed from this image soon.

Owner

elgalu commented Mar 18, 2016

First of all, great work.

Thanks :)

If I use SC in your GRID is it supposed to send jobs to SauceLabs

I wish! but no, there is no logic for that, SC will be removed from this image soon.

@avcarrillo

This comment has been minimized.

Show comment
Hide comment
@avcarrillo

avcarrillo Mar 18, 2016

OIC,

So what is the purpose of SC/BrowserStack in your GRID? What would it be used for?

Also, I have found the Video recording functionality very useful in tracking down random tests failures. I have a test suite of 70 tests, and 2 or 3 different tests would fail each time. It was difficult to track down, so I modified your GRID to create a separate video for each test, and could play back the one that failed. Do you already have plans on adding this functionality to your source? If not I can contribute, but I don't know if my method is the best approach. I have a separate script reading the Selenium logs for "Starting ChromeDriver" and "delete session". This kicks off start-video and stop-video with different names. It creates video-1, video-2, and so on. I'm working on passing the test name through capabilities so I can actually name the video file the same as the test.

avcarrillo commented Mar 18, 2016

OIC,

So what is the purpose of SC/BrowserStack in your GRID? What would it be used for?

Also, I have found the Video recording functionality very useful in tracking down random tests failures. I have a test suite of 70 tests, and 2 or 3 different tests would fail each time. It was difficult to track down, so I modified your GRID to create a separate video for each test, and could play back the one that failed. Do you already have plans on adding this functionality to your source? If not I can contribute, but I don't know if my method is the best approach. I have a separate script reading the Selenium logs for "Starting ChromeDriver" and "delete session". This kicks off start-video and stop-video with different names. It creates video-1, video-2, and so on. I'm working on passing the test name through capabilities so I can actually name the video file the same as the test.

@elgalu

This comment has been minimized.

Show comment
Hide comment
@elgalu

elgalu Mar 18, 2016

Owner

So what is the purpose of SC/BrowserStack in your GRID? What would it be used for?

Shouldn't be used, is a proof of concept.

found the Video recording functionality very useful in tracking down random tests failures

Awesome!!! :)

create a separate video for each test

Great idea! though the proper implementation wouldn't be parsing log files IMO but rather write a Selenium proxy handler that adds this custom logic, see:
https://github.com/rossrowe/sauce-grid-plugin
https://github.com/freynaud/grid-plugin-tutorial
https://github.com/calabash-driver/grid-calabash-node-plugin
https://github.com/jenkinsci/selenium-plugin
https://github.com/groupon/Selenium-Grid-Extras

The logic to parse the capatibilites could also live there, in that grid-plugin java code.

You could potentially include logic to forward test to Sauce Labs when the capabilities are not satisfied by docker-selenium, see:
https://github.com/rossrowe/sauce-grid-plugin/wiki#usage
http://sauceio.com/index.php/2012/09/introducing-the-sauce-plugin-for-selenium-grid/

And also, imagine that for every new session a new docker-selenium container is created and disposed when the session ends, that would be lovely, make docer run / docker stop transparent to the users by invoking docker from that same grid-plugin using some docker java bindings, e.g. https://github.com/docker-java/docker-java

I would love to see any of that functionality added :)

Owner

elgalu commented Mar 18, 2016

So what is the purpose of SC/BrowserStack in your GRID? What would it be used for?

Shouldn't be used, is a proof of concept.

found the Video recording functionality very useful in tracking down random tests failures

Awesome!!! :)

create a separate video for each test

Great idea! though the proper implementation wouldn't be parsing log files IMO but rather write a Selenium proxy handler that adds this custom logic, see:
https://github.com/rossrowe/sauce-grid-plugin
https://github.com/freynaud/grid-plugin-tutorial
https://github.com/calabash-driver/grid-calabash-node-plugin
https://github.com/jenkinsci/selenium-plugin
https://github.com/groupon/Selenium-Grid-Extras

The logic to parse the capatibilites could also live there, in that grid-plugin java code.

You could potentially include logic to forward test to Sauce Labs when the capabilities are not satisfied by docker-selenium, see:
https://github.com/rossrowe/sauce-grid-plugin/wiki#usage
http://sauceio.com/index.php/2012/09/introducing-the-sauce-plugin-for-selenium-grid/

And also, imagine that for every new session a new docker-selenium container is created and disposed when the session ends, that would be lovely, make docer run / docker stop transparent to the users by invoking docker from that same grid-plugin using some docker java bindings, e.g. https://github.com/docker-java/docker-java

I would love to see any of that functionality added :)

@avcarrillo

This comment has been minimized.

Show comment
Hide comment
@avcarrillo

avcarrillo Mar 18, 2016

Thank you for the information. I will research and start a new thread if/when I have contributions.

avcarrillo commented Mar 18, 2016

Thank you for the information. I will research and start a new thread if/when I have contributions.

@elgalu elgalu added the enhancement label Apr 14, 2016

@elgalu

This comment has been minimized.

Show comment
Hide comment
@elgalu

elgalu Apr 20, 2016

Owner

Since we started talking about other issues here I've moved them to #77 #78 #79

Owner

elgalu commented Apr 20, 2016

Since we started talking about other issues here I've moved them to #77 #78 #79

@elgalu elgalu changed the title from Documentation Request to Why Sauce Connect and BrowserStack Local are on this image May 5, 2016

@elgalu elgalu added question and removed enhancement labels May 5, 2016

@diemol

This comment has been minimized.

Show comment
Hide comment
@diemol

diemol Dec 19, 2016

Collaborator

Just to jump in, all the desired features mentioned here are already part of Zalenium, except the Sauce Connect and BrowserStack local (which are coming soon in a release in the near future).

To recap:

  • Tests are forwarded to BrowserStack/Sauce Labs when they cannot be executed in docker-selenium.
  • Videos are created when the test starts and stopped when the test finishes. Also the name can be customised by passing a capability name in the test capabilities.

Would be cool if you can try it since we need some more feedback from external users.

Collaborator

diemol commented Dec 19, 2016

Just to jump in, all the desired features mentioned here are already part of Zalenium, except the Sauce Connect and BrowserStack local (which are coming soon in a release in the near future).

To recap:

  • Tests are forwarded to BrowserStack/Sauce Labs when they cannot be executed in docker-selenium.
  • Videos are created when the test starts and stopped when the test finishes. Also the name can be customised by passing a capability name in the test capabilities.

Would be cool if you can try it since we need some more feedback from external users.

@elgalu

This comment has been minimized.

Show comment
Hide comment
@elgalu

elgalu Jan 23, 2017

Owner

UPDATE @diemol has already added/merged Zalenium support for 3 providers: Sauce Labs, BrowserStack, Testing Bot.

Owner

elgalu commented Jan 23, 2017

UPDATE @diemol has already added/merged Zalenium support for 3 providers: Sauce Labs, BrowserStack, Testing Bot.

@elgalu

This comment has been minimized.

Show comment
Hide comment
@elgalu

elgalu Jan 23, 2017

Owner

I'll remove Sauce Labs & BrowserStack from this image as we want to provide that only through Zalenium.

This will be a breaking change in the next docker-selenium release 3.0.1-p5

Owner

elgalu commented Jan 23, 2017

I'll remove Sauce Labs & BrowserStack from this image as we want to provide that only through Zalenium.

This will be a breaking change in the next docker-selenium release 3.0.1-p5

@elgalu elgalu closed this Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment