New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes and cleanup #13
Comments
Is it safe to merge in master or you want me to cherry pick these three? (you can always put all of them in a branch and do a single pr) |
I'm pretty sure those are the only three commits I made. I made a pull request against my master. The diff looks a bit reduntant due to branch merges. |
Want to tag a release after reviewing those commits? Current release prevents using Mongoid 3, and using git versions of gems makes me nervous :) |
I can release an rc now. Since we're without specs and I'm not using it on a real project (these days) I don't feel confident enough to do a full release. Probably a |
Can you do a pull req from master, I need to discuss a couple of commits (in the meanwhile I'll release the gem) |
See #14 |
I have a number of pull requests in the queue, and I've gotten tired of opening new ones. You may just want to pull my repo to get bug fixes and cleanup like:
https://github.com/jpmckinney/activeadmin-mongoid/commit/9acba82c8a3c7a969e3200a29d3c38b2b313a525
https://github.com/jpmckinney/activeadmin-mongoid/commit/c97170fec1176e112c9706b496d806abe662aa96
https://github.com/jpmckinney/activeadmin-mongoid/commit/bc5e1197e5f57346588aeebab11797090c5e917c
The text was updated successfully, but these errors were encountered: