Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stitch doesn't use "trivial" #6

Open
EliahKagan opened this issue Feb 11, 2023 · 0 comments
Open

stitch doesn't use "trivial" #6

EliahKagan opened this issue Feb 11, 2023 · 0 comments

Comments

@EliahKagan
Copy link
Owner

EliahKagan commented Feb 11, 2023

The stitch script is not using the trivial variable:

extents/stitch

Line 81 in 5912d5d

# $trivial matches fiemap's last output line for an empty file (no captures).

The shellcheck run, correctly performed since #5, reveals that it is unused:

https://github.com/EliahKagan/extents/actions/runs/4151965951/jobs/7182603038#step:3:25

That warning appears to be correct.

I'm not sure how I missed this, because although shellcheck was not being correctly run via CI prior to #5, I did run it myself when developing extents, as well as test the case where the file being examined and recreated is empty. But indeed, I do not seem to ever actually use the trivial variable. This needs to be looked into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant