Fix: Backslash-escaped syntax is not for Windows

http_prompt/execution.py

@@ -126,6 +126,14 @@ def generate_cmds_with_explanations(summary, cmds):
     return text
 
 
+if sys.platform == 'win32':  # nocover
+    def normalize_filepath(path):
+        return unquote(path)
+else:
+    def normalize_filepath(path):
+        return unescape(unquote(path))
+
+
 class DummyExecutionListener(object):
 
     def context_changed(self, context):
@@ -217,12 +225,12 @@ def visit_redir_out(self, node, children):
         else:
             mode = 'wb'
 
-        filename = unquote(path)
+        filename = normalize_filepath(path)
         self.output = FileWriter(open(filename, mode))
         return node
 
     def visit_exec(self, node, children):
-        path = unescape(unquote(children[3]))
+        path = normalize_filepath(children[3])
         with io.open(path, encoding='utf-8') as f:
             # Wipe out context first
             execute('rm *', self.context, self.listener)
@@ -231,7 +239,7 @@ def visit_exec(self, node, children):
         return node
 
     def visit_source(self, node, children):
-        path = unescape(unquote(children[3]))
+        path = normalize_filepath(children[3])
         with io.open(path, encoding='utf-8') as f:
             for line in f:
                 execute(line, self.context, self.listener)

tests/test_execution.py

@@ -318,6 +318,8 @@ def test_source_quoted_filename(self):
             '--verify': 'no'
         })
 
+    @pytest.mark.skipif(sys.platform == 'win32',
+                        reason="Windows doesn't use backslashes to escape")
     def test_source_escaped_filename(self):
         new_filename = self.filename + r' copy'
         shutil.copyfile(self.filename, new_filename)
@@ -412,6 +414,8 @@ def test_exec_quoted_filename(self):
             'username': 'jane'
         })
 
+    @pytest.mark.skipif(sys.platform == 'win32',
+                        reason="Windows doesn't use backslashes to escape")
     def test_exec_escaped_filename(self):
         new_filename = self.filename + r' copy'
         shutil.copyfile(self.filename, new_filename)
@@ -1116,6 +1120,22 @@ def test_httpie_redirect_write_quoted_filename(self):
             content = f.read()
         self.assertEqual(content, 'http http://localhost')
 
+    @pytest.mark.skipif(sys.platform == 'win32',
+                        reason="Windows doesn't use backslashes to escape")
+    def test_httpie_redirect_write_escaped_filename(self):
+        filename = self.make_tempfile()
+        filename += r' copy'
+
+        # Write something first to make sure it's a full overwrite
+        with open(filename, 'w') as f:
+            f.write('hello world\n')
+
+        execute('httpie > %s' % filename.replace(' ', r'\ '), self.context)
+
+        with open(filename) as f:
+            content = f.read()
+        self.assertEqual(content, 'http http://localhost')
+
     def test_httpie_redirect_write_with_args(self):
         filename = self.make_tempfile()