Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for := separator (#68) #101

Merged
merged 7 commits into from Jan 15, 2017
Merged

Add support for := separator (#68) #101

merged 7 commits into from Jan 15, 2017

Conversation

eliangcs
Copy link
Contributor

No description provided.

@eliangcs
Copy link
Contributor Author

@fogine would you like to review this PR? Thanks!

@fogine
Copy link
Contributor

fogine commented Jan 14, 2017

@eliangcs , overall this feature seems to be well implemented. I've stumbled upon small issue with exporting json string values (fix provided in PR). Everything else works as expected.

Before this gets merged, I'd like to propose a change for used json parser though.
Please, take a look at json5 extension - respectively python-json5. It'd make work with json inside http-prompt much more enjoyable as it eases some strict rules.

Thanks!

@eliangcs
Copy link
Contributor Author

eliangcs commented Jan 15, 2017

@fogine json5 support is nice, but let's do it in another PR. You're welcome to create a PR if you have time to do it :)

If you were to implement json5 support, instead of using pyjson5 as a hard requirement, make sure it uses pyjson5 as a fallback of Python's builtin json, i.e., use pyjson5 only when Python's builtin json fails. pyjson5 does not seem to well maintained (last release was in 2015), so I don't want to rely on it too much.

@eliangcs eliangcs merged commit 1335e83 into master Jan 15, 2017
@eliangcs eliangcs deleted the issue/68-raw-json branch January 15, 2017 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants