Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android plugin handles annotations URIs differently than Mac/Windows, plus other bugs #155

Open
ryanwwest opened this issue Mar 13, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@ryanwwest
Copy link

ryanwwest commented Mar 13, 2022

I sync my Obsidian vault (including .obsidian) across Windows 10, MacOS Monterey , and Android 12 and am currently on Annotator version 0.2.1 across them all. I am able to bring up an EPUB document across all three and make annotations across all three.

However, the annotations that I make in Windows and Mac are not correctly interpreted when in the 'Annotating' mode on Android mode - those annotations show up as 'orphans' in the Hypthos.is client that is being used. The reverse is true - any annotations I make from within Android show up as 'orphans' on both Windows and Mac.

I think I know why: On annotations created by Windows and Mac, the annotation-json includes a key "uri":"app://obsidian.md/index.html?loc=Text/main.xhtml", and another subkey "source":"app://obsidian.md/index.html?loc=Text/main.xhtml". However, on annotations created from Android, the annotation-json instead has a "uri":"http://localhost/?loc=Text/main.xhtml" and "source":"http://localhost/?loc=Text/main.xhtml".

Both sets of OS's function within their own URI/source style, but it appears these aren't cross-compatible, so this seems like a bug. I'm guessing using the same URI/source could fix it.

Additionally, I'm experiencing a few other Android-specific bugs (that may or may not be related to the above).

  1. MD files with annotation-target-type: web don't seem to load at all on Android. They work pretty well on Windows+Mac (though some loading bar, and opening external links in an actual browser instead of internally would be nice).
  2. PDF annotations appear normally across all 3 OS's; they don't seem to have the orphan problem as described above. However, sometimes when trying to do an 'annotate' action on Android (not 'highlight'), the Hypothesis sidebar appears to let me enter some text as a note, but after writing my note and tapping away, I can no longer interact with the sidebar at all; any attempts to tap it cause the sidebar to disappear and put me back in the regular pdf.js side. I have to reload the Annotator plugin to fix it and lose the note I tried to add since I couldn't click 'Post to only me'. As a lesser issue, the PDF and EPUB readers aren't particularly mobile-friendly, but I can live with them.
@aladmit aladmit added the bug Something isn't working label May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants