Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sitemap_to_df wrongly handles multiple video tags #87

Closed
eliasdabbas opened this issue Jun 8, 2020 · 2 comments
Closed

sitemap_to_df wrongly handles multiple video tags #87

eliasdabbas opened this issue Jun 8, 2020 · 2 comments

Comments

@eliasdabbas
Copy link
Owner

Video sitemaps allow multiple <video:tag> elements in a sitemap entry. sitemap_to_df only handles the last given tag. It should extract all of them.
@eliasdabbas eliasdabbas mentioned this issue Oct 17, 2020
Closed
@chbg
Copy link

chbg commented Jul 28, 2022

@eliasdabbas , is this still an issue?

@eliasdabbas
Copy link
Owner Author

@chbg Unfortunately, yes.

It would require a re-write, and I haven't found the time. Hopefully soon. Any contributions/suggestions are welcomed of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chbg @eliasdabbas