Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom captures are not importing. #317

Open
frezap opened this issue Apr 18, 2024 · 3 comments
Open

Custom captures are not importing. #317

frezap opened this issue Apr 18, 2024 · 3 comments

Comments

@frezap
Copy link

frezap commented Apr 18, 2024

The venice sample imports fine.

  • The .rdc file: https://file.io/pE4ZnO8QY2Im
  • Your GPU: Nvidia GTX
  • Version of this add-on: 0.7.0
  • Version of RenderDoc: 1.31
  • Version of Blender: 4.1

Logs:

google_maps_rd failed and returned: Loading capture from ...rdctest.rdc... Trying scraping strategy #4 (from draw call #0)... (Skipping drawcall ClearDepthStencilView()) (Skipping drawcall ClearView()) (Skipping drawcall Draw()) (Skipping drawcall Draw()) Not relevant yet: ClearRenderTargetView() Not relevant yet: ClearDepthStencilView() Not relevant yet: ClearView() Not relevant yet: Draw() Not relevant yet: Draw() Not relevant yet: ClearDepthStencilView() Not relevant yet: ClearDepthStencilView() Not relevant yet: Draw() Not relevant yet: ClearDepthStencilView() Not relevant yet: ClearDepthStencilView() Not relevant yet: DiscardView() Not relevant yet: DiscardView() Not relevant yet: ClearRenderTargetView() Not relevant yet: DrawInstanced() Not relevant yet: DrawInstanced() Not relevant yet: ClearDepthStencilView() Not relevant yet: DrawInstanced() Not relevant yet: DrawInstanced() Traceback (most recent call last): File "...AppData\Blender\Blender\4.1\scripts\addons\MapsModelsImporter\google_maps_rd.py", line 377, in <module> main(controller) File "...AppData\Blender\Blender\4.1\scripts\addons\MapsModelsImporter\google_maps_rd.py", line 369, in main scraper.run() File "...AppData\Blender\Blender\4.1\scripts\addons\MapsModelsImporter\google_maps_rd.py", line 278, in run relevant_drawcalls, capture_type = self.extractRelevantCalls(drawcalls) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "...AppData\Blender\Blender\4.1\scripts\addons\MapsModelsImporter\google_maps_rd.py", line 214, in extractRelevantCalls return self.extractRelevantCalls(drawcalls, _strategy=_strategy+1) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "...AppData\Blender\Blender\4.1\scripts\addons\MapsModelsImporter\google_maps_rd.py", line 176, in extractRelevantCalls if not skipped_drawcalls or self.hasUniform(skipped_drawcalls[0], "_uMeshToWorldMatrix"): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "...AppData\Blender\Blender\4.1\scripts\addons\MapsModelsImporter\google_maps_rd.py", line 142, in hasUniform constants = self.getVertexShaderConstants(draw) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "...AppData\Blender\Blender\4.1\scripts\addons\MapsModelsImporter\google_maps_rd.py", line 132, in getVertexShaderConstants elif var.type == rd.VarType.Int: ^^^^^^^^^^^^^^ File "...Blender Foundation\Blender 4.1\4.1\python\Lib\enum.py", line 784, in __getattr__ raise AttributeError(name) from None AttributeError: Int. Did you mean: 'SInt'?

@eliemichel
Copy link
Owner

This was a bug indeed, thanks for sharing the rdc file! You may replace your ...AppData\Blender\Blender\4.1\scripts\addons\MapsModelsImporter\google_maps_rd.py file with this new one: google_maps_rd.py, let me know if it works I'll make a new release!

image

@CL-matt
Copy link

CL-matt commented Apr 22, 2024

This was a bug indeed, thanks for sharing the rdc file! You may replace your ...AppData\Blender\Blender\4.1\scripts\addons\MapsModelsImporter\google_maps_rd.py file with this new one: google_maps_rd.py, let me know if it works I'll make a new release!

image

After the google_maps_rd_py had been replaced to the new one, it works. But there is a new problem... The model is incomplete.
My device:
The rdc file: https://file.io/U5z4ypR2w3lD
Your GPU: Nvidia GTX 4060
Version of this add-on: 0.7.0
Version of RenderDoc: 1.31
Version of Blender: 4.1
Screenshot in Blender:
imagen
Screenshot RenderDoc:
imagen

@frezap
Copy link
Author

frezap commented Apr 22, 2024

Importing custom captures works now on my end. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants