Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline avatars display inconsistently #63

Open
danielbprice opened this issue Oct 25, 2019 · 2 comments
Open

Inline avatars display inconsistently #63

danielbprice opened this issue Oct 25, 2019 · 2 comments

Comments

@danielbprice
Copy link
Contributor

I noticed that <avatar inline>'s with src set versus those with username set have inconsistent alignment with surrounding inline text. The following fiddle hopefully illustrates the problem: https://jsfiddle.net/hnyao14r/2/

Screen Shot 2019-10-24 at 9 09 03 PM

I also show a minor tweak-- adding a zero width space to the wrapper <div>-- which seems to help the situation. I'm not sure I understand enough about CSS and alignment and baselines to know why. Thanks for this nice component!

@saintplay
Copy link
Collaborator

Great catch. However there is no rule to make the baseline always center, with avatars looks good though. I suggest using flex and align-items always for inline items

@danielbprice
Copy link
Contributor Author

FWiW I think this is what this commit: corstian@17e5a51 is also trying to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants