runPython is causing an infinite loop

[holdenmatt]

I may be using the usePython hook differently than you intend, but it's currently causing an infinite loop for me.

I have code like:

const { runPython, ... } = usePython();

useEffect(() => {
  const code = ...
  runPython(code)
  ...
}, [runPython, ...]);

The problem is the runPython function isn't memoized, so it gets re-defined on each hook call. This causes useEffect to get triggered in an infinite loop.

I think (?) the fix is to wrap runPython in a useCallback where you define it here:
https://github.com/elilambnz/react-py/blob/main/src/hooks/usePython.ts#L180

You may want to consider doing this for other functions your hooks return, so they won't change for callers on every render.

[elilambnz]

Thanks, I'll investigate this.

Any reason for passing the runPython function as a dependency to your useEffect? TIL. Will make this change when I next have a moment to do so, otherwise feel free to open a PR.

[holdenmatt]

Cool, thanks for considering.

Yeah, I've removed it for now to fix this issue, but it requires disabling a lint rule, which isn't ideal. Not a blocker / urgent, but guessing others will run into this as well, so just a suggestion!

[elilambnz]

Please try out version 1.8.5, this should now be fixed. I have tested it, but please let me know if you run into any further issues with this.