Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement of CSS on Card Size in Image List #1503

Open
Shubham-Vishwakarma opened this issue Jan 25, 2022 · 3 comments
Open

Enhancement of CSS on Card Size in Image List #1503

Shubham-Vishwakarma opened this issue Jan 25, 2022 · 3 comments
Labels
good first issue Good for newcomers ux/ui User Experience (UX) / User Interface (UI)

Comments

@Shubham-Vishwakarma
Copy link
Contributor

Enhancement of Card Alignment
This is an enhancement of card alignment wherever possible

To Reproduce
Steps to reproduce the behavior:

  1. After Sign in Go to 'http://eng.elimu.ai/content/multimedia/image/list'
  2. Scroll down to the pages
  3. You can see the card are not properly aligned

Expected behavior
Each row should have 3 cards of the same width and height

Screenshots
image

Additional context
Possible solution

  1. Define a max-width to the card
  2. For the images inside the card, either resize them to the same size using photoshop or a similar tool
    OR
    Define fixed size and set overflow to hidden.
  3. If you have an any better idea, please go ahead with it.
@nya-elimu nya-elimu added ux/ui User Experience (UX) / User Interface (UI) good first issue Good for newcomers labels Jan 25, 2022
@nya-elimu
Copy link
Member

nya-elimu commented Jan 25, 2022 •
edited by jo-elimu
Loading

Corresponding JSP file: https://github.com/elimu-ai/webapp/blob/main/src/main/webapp/WEB-INF/jsp/content/multimedia/image/list.jsp

@jacobmass jacobmass self-assigned this Jan 25, 2022
@nya-elimu
Copy link
Member

By the way, we have a similar UI issue at http://eng.elimu.ai/content/contributor/list

Screen Shot 2022-01-25 at 9 21 44 PM

@nya-elimu
Copy link
Member

@Shubham-Vishwakarma Would you like some assistance on this issue? 🙂

@nya-elimu nya-elimu changed the title Enhancement of CSS on Card Size Enhancement of CSS on Card Size in Image List Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers ux/ui User Experience (UX) / User Interface (UI)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nya-elimu @Shubham-Vishwakarma @jacobmass