Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default UnrealScript snippets #149

Closed
Shtoyan opened this issue Jan 4, 2023 · 6 comments
Closed

Default UnrealScript snippets #149

Shtoyan opened this issue Jan 4, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Shtoyan
Copy link
Contributor

Shtoyan commented Jan 4, 2023

Describe the solution you'd like

Is it technically possible to add some basic, default snippets here, without creating a standalone snippet extension? Something like these: https://github.com/InsultingPros/LazyKFWiki/blob/main/docs/_content/unrealscript.json

They are really helpful, not mandatory and if you add them, people will be able to easily modify them instead of writing from scratch.

@EliotVU EliotVU added the enhancement New feature or request label Jan 6, 2023
@EliotVU EliotVU added this to the Next milestone Jan 6, 2023
@EliotVU EliotVU self-assigned this Jan 6, 2023
@EliotVU
Copy link
Owner

EliotVU commented Jan 6, 2023

That's a good idea. I will push some basic snippets shortly!

@EliotVU
Copy link
Owner

EliotVU commented Jan 6, 2023

Ah, forgot to add structdefaultproperties and a snippet for interface :)

EliotVU added a commit that referenced this issue Jan 6, 2023
@EliotVU
Copy link
Owner

EliotVU commented Jan 6, 2023

I think this issue can be closed now, but I'll leave it open for review.

@Shtoyan
Copy link
Contributor Author

Shtoyan commented Jan 6, 2023

Wow, that's much more than I was expecting.

From my little testing:

  • There is no case for local variables.
  • Maybe add Role==ROLE_Authority by default instead of condition string?
  • There is a typo in replication block so it doesn't have a closing bracket.
    image
  • There is a whitelist instead of ; for new.
  • Maybe add BeginState() / EndState() for state?

EliotVU added a commit that referenced this issue Jan 6, 2023
@EliotVU
Copy link
Owner

EliotVU commented Jan 6, 2023

Fixed :)

  • As for role by default, this is an unnecessary condition if (bNetDirty or bNetInitial) is all that's needed, ROLE_Authority is always implied.
  • Not sure, is this the very first thing to write when creating a state?

@Shtoyan
Copy link
Contributor Author

Shtoyan commented Jan 6, 2023

On the second thought... yeah, this is more than enough. Other tweaks can be easily done on top of this.

Thanks a lot!

@EliotVU EliotVU closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants