Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-threading #34

Closed
TheLastGimbus opened this issue Aug 6, 2022 · 4 comments · Fixed by #74
Closed

Multi-threading #34

TheLastGimbus opened this issue Aug 6, 2022 · 4 comments · Fixed by #74
Assignees
@elisemercury
Labels
feature : new New feature for difPy. status : implemented Feature was implemented in difPy.

Comments

@TheLastGimbus
Copy link

Hi!
I have nice AMD cpu with 8 cores. And when I'm searching thorough 2 big folders, it takes a lof of time because only one of them is being use

Dividing the work into multiple threads seems as obvious task in this library - would be awesome if you implemented it! (or suggested how it could be done for someone to pull request)
@elisemercury
Copy link
Owner

elisemercury commented Aug 15, 2022 •
edited

Hi @TheLastGimbus,
Thanks a lot for your feedback! I will definitely look into your idea, but am currently not planning to add such a feature to difPy. In the meantime, if you want to implement this feature yourself, feel free to open a pull request to this repo.
Thanks and all the best,
Elise

@elisemercury elisemercury added the feature : new New feature for difPy. label Aug 15, 2022
@elisemercury elisemercury reopened this Sep 23, 2022
@elisemercury elisemercury self-assigned this Sep 23, 2022
@elisemercury elisemercury added the status : unlikely Feature will probably not be implemented in difPy. label Mar 25, 2023
@TheLastGimbus
Copy link
Author

Did this got implemented?

@elisemercury elisemercury added status : in progress Feature is currently being implemented in difPy. and removed status : unlikely Feature will probably not be implemented in difPy. labels Aug 26, 2023
@elisemercury elisemercury reopened this Aug 26, 2023
@elisemercury
Copy link
Owner

Hi @TheLastGimbus,

I'm happy to let you know that difPy v4 now comes with multiprocessing. Thanks for your suggestion!

All the best,
Elise

@elisemercury elisemercury added status : implemented Feature was implemented in difPy. and removed status : in progress Feature is currently being implemented in difPy. labels Aug 31, 2023
@elisemercury elisemercury linked a pull request Aug 31, 2023 that will close this issue
Updates to v4 #74
Merged
@TheLastGimbus
Copy link
Author

I'm always happy to get a notifiaction about new stuff here! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elisemercury elisemercury

Labels
feature : new New feature for difPy. status : implemented Feature was implemented in difPy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates to v4 elisemercury/Duplicate-Image-Finder
2 participants
@TheLastGimbus @elisemercury