Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-processing #41

Closed
thecodingchicken opened this issue Sep 20, 2022 · 4 comments · Fixed by #74
Closed

Multi-processing #41

thecodingchicken opened this issue Sep 20, 2022 · 4 comments · Fixed by #74
Assignees
Labels
feature : new New feature for difPy. status : implemented Feature was implemented in difPy.

Comments

@thecodingchicken
Copy link

I am currently working on making this project multithreaded, as I have many folders with tens of thousands of images(perhaps 100k+), and am wanting a slightly faster option.

Opening this as a means of communication. If you have a discord account/email that would work better, as I will likely see that before a github issue comment.
My discord account is thecodingchicken#4835 if you would prefer to reach out there.

@elisemercury
Copy link
Owner

Hi @thecodingchicken,
Thank you very much for reaching out and for sharing your feedback!
We already received a few requests similar to yours, and therefore decided to implement batch processing in the next upcoming release of difPy. Therefore, with this there will also be an option to multi-thread the process. This release is in ongoing development, and there is no confirmed release date yet. Please therefore, be patient and soon processing on difPy will become a lot more flexible, and scalable. :-)
Again thanks and all the best,
Elise

@elisemercury elisemercury added the feature : new New feature for difPy. label Sep 23, 2022
@elisemercury elisemercury self-assigned this Sep 23, 2022
@thecodingchicken
Copy link
Author

Just an update. Code is almost working, just have to sort out a few minor issues that break everything. Seems to be the norm for me, as I haven't really done any coding in years.
Glad to hear that you are working on it as well. Is it multithreaded in another language? As I know the GIL prevents you from running many threads that are CPU-bound. Hence why multiprocessing seems to be the only option for me, assuming that you stick in CPython, as compared to IronPython or Jython

@elisemercury
Copy link
Owner

Hi @thecodingchicken,
Great to hear you are working on it as well and that you're almost done! Congrats. Feel free to open a pull request when you're done - I would love to see what approach you took.
I am working on it as well yes, but as I have currently quite a few other things I am working on, it will still take a bit to be finalized. I am planning to use the Python multiprocessing library, as well as implement the ability to input images to difPy in batches, and save the process state so that it can be resumed if interrupted.
All the best and happy coding!
Elise

@elisemercury elisemercury added the status : unlikely Feature will probably not be implemented in difPy. label Mar 25, 2023
@elisemercury elisemercury added status : in progress Feature is currently being implemented in difPy. and removed status : unlikely Feature will probably not be implemented in difPy. labels Aug 26, 2023
@elisemercury elisemercury reopened this Aug 26, 2023
@elisemercury
Copy link
Owner

Hi @thecodingchicken,

I'm happy to let you know that difPy v4 now comes with multiprocessing. Thanks for your suggestion!

All the best,
Elise

@elisemercury elisemercury linked a pull request Aug 31, 2023 that will close this issue
@elisemercury elisemercury added status : implemented Feature was implemented in difPy. and removed status : in progress Feature is currently being implemented in difPy. labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature : new New feature for difPy. status : implemented Feature was implemented in difPy.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants