Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect sessions without trailing slash to session with trailing slash #5

Open
strazto opened this issue Apr 14, 2021 · 1 comment · May be fixed by #7
Open

Redirect sessions without trailing slash to session with trailing slash #5

strazto opened this issue Apr 14, 2021 · 1 comment · May be fixed by #7
Labels
enhancement New feature or request

Comments

@strazto
Copy link

strazto commented Apr 14, 2021

Migrating from elisescu/tty-share#34 , as I realized this redirection is handled by the proxy

Somewhat similar to:
elisescu/tty-server#15

essentially, if i have the link tty-share.com/s/​<session_id>​/, if I click to tty-share.com/s/​<session_id> ​ , I get a 404

These urls should probably be treated as equivalent, as the default behaviour of many terminals does not include the trailing slash
This was referenced Apr 14, 2021
Closed
Open
@elisescu elisescu added the enhancement New feature or request label Feb 5, 2022
@elisescu
Copy link
Owner

elisescu commented Feb 5, 2022

I had a comment in the PR. I think the change makes sense without the logging part :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

redirect sessions w/o trailing slash strazto/tty-proxy
2 participants
@elisescu @strazto