Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconnect logic to proxy client #63

Open
Mic92 opened this issue Nov 27, 2022 · 1 comment
Open

Add reconnect logic to proxy client #63

Mic92 opened this issue Nov 27, 2022 · 1 comment

Comments

@Mic92
Copy link

Mic92 commented Nov 27, 2022

From reading the client code there is no support for reconnect if the others side network was dropped.
This seems not optimal if the network gets disconnected when using the proxy

@Mic92 Mic92 changed the title Reconnect logic Add reconnect logic to proxy client Nov 27, 2022
@elisescu
Copy link
Owner

elisescu commented Jun 5, 2023

Sorry for the very long delay, @Mic92 .
This is something I'd like to add at some point, but it's a bit thicker than it seems. If the connection is dropped, the server needs to identify the client somehow with the right session, and there's no concept like that built in tty-proxy to support it. Right now, the TCP connection lifecycle maps to the lifecycle of a session - if the TCP connection dies, the session is invalidated. Otherwise, the server would need to maintain some more state.
I'll keep this open, as I agree - it would be nice to have something like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants