Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored mypy errors #144

Open
kushagra189 opened this issue Sep 29, 2022 · 0 comments · May be fixed by #200
Open

Fix ignored mypy errors #144

kushagra189 opened this issue Sep 29, 2022 · 0 comments · May be fixed by #200
Assignees
Labels
priority: high High priority type: maintenance Related to general repository maintenance workload: days Likely takes days to resolve
Milestone

Comments

@kushagra189
Copy link
Contributor

Currently, for the sake of completing the pipeline, we have ignored certain mypy errors. We need to work on a solution in order to make our code implementation compatible with mypy standards without ignoring these lines.

Suggestion:
The majority errors are due to the class-based implementation of foca in order to access it as a property of the Flask Config class. Hence one recommendation is to make the Foca app somehow a parent of the Connexion app, in a similar way that the Connexion app is a parent of the Flask app. Or to extend the Flask app (inside the Connexion) in a way that it has a property foca of type Config.

@kushagra189 kushagra189 self-assigned this Sep 29, 2022
@kushagra189 kushagra189 added status flag: discuss Needs input from various people type: bug Something isn't working type: ci / cd Related to continuous integration / delivery type: maintenance Related to general repository maintenance workload: days Likely takes days to resolve labels Sep 29, 2022
@uniqueg uniqueg added priority: high High priority and removed status flag: discuss Needs input from various people type: bug Something isn't working type: ci / cd Related to continuous integration / delivery labels Dec 2, 2023
@uniqueg uniqueg modified the milestones: v1.0.0, v0.13.0 Dec 2, 2023
@kushagra189 kushagra189 self-assigned this Dec 10, 2023
@kushagra189 kushagra189 linked a pull request Dec 24, 2023 that will close this issue
10 tasks
@uniqueg uniqueg modified the milestones: v0.13.0, v1.0.0 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority type: maintenance Related to general repository maintenance workload: days Likely takes days to resolve
Projects
Status: Todo other
Development

Successfully merging a pull request may close this issue.

2 participants