Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for configuring Splash Fetcher should be base_url not base_splash_url #84

Closed
rnice01 opened this issue Apr 16, 2020 · 2 comments
Closed

Comments

@rnice01
Copy link

rnice01 commented Apr 16, 2020

Docs for Basic Concepts and configuring Splash fetcher state the configuration should be
fetcher: {Crawly.Fetchers.Splash, [base_splash_url: "http://localhost:8050/render.html"]}

However, the fetch method is looking for the base_url keyword in the config. As seen here

The message for the error, here, should be updated too.

@Ziinc
Copy link
Collaborator

Ziinc commented Apr 19, 2020

It seems like there a lot of documentation errors. I'll do up a PR to consolidate efforts from #85 as well.

@oltarasenko
Copy link
Collaborator

This is done now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants