Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON encoder should be a no-op in postgres versions that do not support #82

Closed
josevalim opened this issue Jun 23, 2015 · 2 comments
Closed

JSON encoder should be a no-op in postgres versions that do not support #82

josevalim opened this issue Jun 23, 2015 · 2 comments

Comments

@josevalim
Copy link
Member

Currently, using the JSON type will break Postgrex on versions 9.1 and earlier. The type should not cause errors on postgres versions that do not support it.
@ericmj
Copy link
Member

ericmj commented Jun 23, 2015

The JSON encoder should only run if the server is actually asking the client to encode json, which it of course shouldn't if it doesn't support it.

@ericmj
Copy link
Member

ericmj commented Nov 16, 2015

Is this is an actual bug? I don't see how this is a postgrex bug, if the json type isn't supported the server should return an error response. Do you remember what the issue was?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josevalim @ericmj