Feature: Navigate from defdelegate to the function delegated to

[axelson]

May require changes to elixir_sense

[lukaszsamson]

It will require changes in elixir sense. I was planning to do this anyway though.

[axelson]

That sounds good, I created an issue in the elixir_sense repo as well: elixir-lsp/elixir_sense#89

[IvanShpotenko]

So is it possible now to navigate to the delegated function?
If so, how can this be done? Or is there some additional work required to do so?

Currently, it seems like I can only see peek definition (which is displayed correctly).
But as for navigation, I am able to navigate from the function call to the defdelegate definition and then from the defdelegate definition to the module that is delegated to, but from there you’ll have to manually search for the function in question.

Sorry if am missing smth obvious :)

[lukaszsamson]

@IvanShpotenko use go to implementation instead of go to definition

[IvanShpotenko]

Thanks, it works! Sorry for the confusion!

[giddie]

It seems if I'm at the defdelegate site, I need to jump back to the call site and do go-to-implementation to jump through the delegation. Is there a way to jump directly from the delegation to the implementation without jumping back to the call site?

Also, it seems that listing references doesn't work from the function implementation (i.e. the target of the delegation). I'd expect that it would list the defdelegate call(s) as references. Should I be doing something differently, or is this not available yet?

[lukaszsamson]

It seems if I'm at the defdelegate site, I need to jump back to the call site and do go-to-implementation to jump through the delegation. Is there a way to jump directly from the delegation to the implementation without jumping back to the call site?

You can use go to implementations on the defdelegate site, no need to jump back to call site (I've just verified it and it works for me)

Also, it seems that listing references doesn't work from the function implementation (i.e. the target of the delegation). I'd expect that it would list the defdelegate call(s) as references. Should I be doing something differently, or is this not available yet?

That's a separate issue. Please fill it in elixir_sense repo

[giddie]

You can use go to implementations on the defdelegate site, no need to jump back to call site (I've just verified it and it works for me)

Ah! OK, I've traced my issue here to an issue with alias resolution:

# lib/test.ex
defmodule Test do
  alias __MODULE__, as: Self
  alias Self.Private

  defdelegate my_function(), to: Private
end

# lib/test/private.ex
defmodule Test.Private do
  def my_function() do
    IO.puts("Hello")
  end
end

It seems that the double-alias involving __MODULE__ breaks resolution, which breaks jump-to-implementation as a side-effect. Where should I report this? Does it go to elixir_sense?

[lukaszsamson]

Where should I report this? Does it go to elixir_sense?

Yes. If you would like to try adding support for it, the relevant code is in https://github.com/elixir-lsp/elixir_sense/blob/219b4d0fcb27c46dd4dad915ece01ec2b92d0249/lib/elixir_sense/core/metadata_builder.ex#L705