You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Taking a look into sneako/finch#186, I've found the case where :gen_tcp.connect/4 throws :badarg which mint is unable to handle. Is it in mint's scope to take care of it? Personally I'd find it great if it was since I feels that zero byte strings are not inconsistent with Mint.Types.address() which contains String.t(). What do you think?
I believe the problem is not that Mint crashes for this value but that the reason is very opaque. A common solution is to add additional information in accordance with https://www.erlang.org/eeps/eep-0054. Given it is an exit we cannot do that though. So unfortunately I don’t think Mint can do much about it. (It could special case "" but eg "/(*" would be invalid too.) I think the real fix would have to happen in OTP.
Hi, thanks for the feedback and the link. I had a feeling that this is maybe OTP issue, but I was not very sure about it and asked here beforehand. But thanks to your comment I guess it's making sense to me. I'll be reporting it in OTP after a little more research. Thanks a lot!
Taking a look into sneako/finch#186, I've found the case where
:gen_tcp.connect/4
throws:badarg
which mint is unable to handle. Is it in mint's scope to take care of it? Personally I'd find it great if it was since I feels that zero byte strings are not inconsistent withMint.Types.address()
which containsString.t()
. What do you think?The text was updated successfully, but these errors were encountered: