Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame.read_parquet and DataFrame.write_parquet #64

Closed
cigrainger opened this issue Sep 22, 2021 · 3 comments · Fixed by #72
Closed

DataFrame.read_parquet and DataFrame.write_parquet #64

cigrainger opened this issue Sep 22, 2021 · 3 comments · Fixed by #72
Labels
kind:feature New feature or request note:good first issue Good for newcomers

Comments

@cigrainger
Copy link
Member

Docs for Polars are here: reading and writing.

I've held back on implementing these as almost certainly a pure elixir backend won't be able to use it. I do think it's worth getting in though. Not sure what the best practice is here: just raising that it's not supported for a given backend?

@cigrainger cigrainger assigned cigrainger and unassigned cigrainger Sep 22, 2021
@cigrainger cigrainger added kind:feature New feature or request note:good first issue Good for newcomers labels Sep 22, 2021
@arpieb
Copy link

arpieb commented Sep 24, 2021

I had actually done some research on this a while back trying to leverage Parquet files from within Elixir. Here are some resources I found but never got a chance to dig deeply into beyond generating the Erlang bindings for the Thrift definition (I was more focused on getting the data processed than tool-building at the time):

@arpieb
Copy link

arpieb commented Sep 24, 2021

FWIW, I think raising an exception on unimplemented for a specific backend would be fine until it is implemented, but doesn't hold up the progression of the explorer package.

For example, Nx didn't hold back on implementing features based on XLA in order to keep libtorch on parity, which is fine.

@cigrainger
Copy link
Member Author

Thanks for that @arpieb! Those are great resources to come back to for the pure Elixir implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature New feature or request note:good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants