Update Polars to v0.28 #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Apr 12, 2023
| @@ -1118,7 +1118,8 @@ pub fn s_not(s1: ExSeries) -> Result<ExSeries, ExplorerError> { | |||
|
|
|||
| #[rustler::nif(schedule = "DirtyCpu")] | |||
| pub fn s_contains(s1: ExSeries, pattern: &str) -> Result<ExSeries, ExplorerError> { | |||
| Ok(ExSeries::new(s1.utf8()?.contains(pattern)?.into())) | |||
| // TODO: maybe have "strict" as an option. | |||
There was a problem hiding this comment.
What would the strict option do?
There was a problem hiding this comment.
The docs don't say much :/
But for what I could understand, it is related to how the Regex is interpreted: https://pola-rs.github.io/polars/src/polars_ops/chunked_array/strings/namespace.rs.html#136
If it's "strict", then the regex must be valid. In case it's not strict and an invalid regex is used, it is going to search for "None" - nils.
There was a problem hiding this comment.
@philss for us contain is never a regex, so we need to make sure our pattern is not being interpreted as a regex.
josevalim
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also applies some of the changes necessary to make our code work for this version.
See the Polars release notes for more details: https://github.com/pola-rs/polars/releases/tag/rs-0.28