Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for labelling coordinates #167

Closed
josevalim opened this issue Jan 25, 2021 · 1 comment
Closed

Add support for labelling coordinates #167

josevalim opened this issue Jan 25, 2021 · 1 comment
Labels
kind:feature New feature or request note:discussion Details or approval are up for discussion

Comments

@josevalim
Copy link
Collaborator

xarray can provide a lot of guidance here: http://xarray.pydata.org/en/stable/

It would also be interesting to see tensor backends that target libraries/formats such as pandas/apache arrow and see the changes that we would need to make to model to support those.

@josevalim josevalim added kind:feature New feature or request note:discussion Details or approval are up for discussion labels Jan 25, 2021
@josevalim
Copy link
Collaborator Author

After reading xarray, they actually use a separate datatype, called Dataset, for their Pandas equivalent, so we would probably need a separate data-type here too.

There is one potential interesting interplay here which is to allow Dataset in defn, but that will only be possible if all Dataset columns are valid tensor types. For example, if a dataset column is a string, then we obviously can't use it in defn. So my suggestion is to explore the dataset approach in a separate library and potentially make each column a tensor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature New feature or request note:discussion Details or approval are up for discussion
Projects
None yet
Development

No branches or pull requests

1 participant