Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groups in convolution #181

Closed
seanmor5 opened this issue Jan 30, 2021 · 0 comments · Fixed by #264
Closed

Support groups in convolution #181

seanmor5 opened this issue Jan 30, 2021 · 0 comments · Fixed by #264
Labels
area:nx Applies to nx kind:feature New feature or request

Comments

@seanmor5
Copy link
Collaborator

Grouped Convolutions are common enough that we should support them. Here's some discussion and papers on grouped convolutions: https://paperswithcode.com/method/grouped-convolution

XLA supports grouped convolutions with it's feature_group_count option (right now we always set it to 1). We will just need to add support for groups in the binary implementation of Nx.conv. This involves an additional iteration in the binary implementation as well as some additional shape checks.

XLA also supports batch_group_count for grouping parts of the batch. I see less value in adding this option as I haven't been able to find any applications that are all that common.

@seanmor5 seanmor5 added the kind:feature New feature or request label Jan 30, 2021
@josevalim josevalim added the area:nx Applies to nx label Feb 12, 2021
This was referenced Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:nx Applies to nx kind:feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants