Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem when using optional for enums #322

Closed
whatyouhide opened this issue Nov 26, 2022 Discussed in #300 · 2 comments
Closed

Problem when using optional for enums #322

whatyouhide opened this issue Nov 26, 2022 Discussed in #300 · 2 comments
Labels
Kind:Invalid An invalid issue: a feature that's already there, a bug not related to this library, and so on.

Comments

@whatyouhide
Copy link
Collaborator

Discussed in #300

Originally posted by nieg675 August 16, 2022
Hello! We are running from commit 48c39d4 to get optional support. However, we experience a problem when using the optional field for enums. If we encode a message that has the optional enum field set to the enum member with tag = 0, we get nil for this field when decoding it. Is this somehow expected, or is it a potential bug?
@whatyouhide whatyouhide added Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work". Kind:Needs More Info Needs more information to investigate. labels Nov 26, 2022
@sindrip
Copy link
Contributor

sindrip commented Nov 28, 2022

I fixed this in #302 and it's already merged

@whatyouhide
Copy link
Collaborator Author

Oh, fantastic 😄 Will go update the discussion. Sorry about that and thanks again @sindrip 💟

@whatyouhide whatyouhide added Kind:Invalid An invalid issue: a feature that's already there, a bug not related to this library, and so on. and removed Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work". Kind:Needs More Info Needs more information to investigate. labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Kind:Invalid An invalid issue: a feature that's already there, a bug not related to this library, and so on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whatyouhide @sindrip