Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoding Invalid Strings sometimes raise MatchError instead of Protobuf.DecodeError #339

Closed
D-Town44 opened this issue Jan 18, 2023 · 0 comments
Labels
Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work".

Comments

@D-Town44
Copy link
Contributor

D-Town44 commented Jan 18, 2023

Hello!

I found that in newer versions of the lib sometimes when you decode an invalid string, a MatchError is raised instead of a Protobuf.DecodeError.

Example:
image

Specifically, I was testing when I tried to decode JSON strings. Seems like some strings still raise the appropriate Protobuf.DecodeError.

Good Example:
image

I think it is related to the added functionality surrounding __unknown_fields__.

Let me know if you have any questions or if there is anything I can do to help!

@whatyouhide whatyouhide added the Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work". label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work".
Projects
None yet
Development

No branches or pull requests

2 participants