Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to skip chromedriver-chrome version match check #697

Closed
michallepicki opened this issue Jul 15, 2022 · 4 comments · Fixed by #698
Closed

Allow to skip chromedriver-chrome version match check #697

michallepicki opened this issue Jul 15, 2022 · 4 comments · Fixed by #698

Comments

@michallepicki
Copy link
Contributor

michallepicki commented Jul 15, 2022 •
edited

After #688 got merged, Wallaby no longer works with chromium on Linux (I think it will not work with a custom installation path on Windows either).

One solution would be to allow the chromedirver-chrome version match check to be skipped.
@mhanberg
Copy link
Member

Are you configuring the chrome binary path or is this with chrome driver finding it on its own?

@michallepicki
Copy link
Contributor Author

Are you configuring the chrome binary path or is this with chrome driver finding it on its own?

Chromedriver is finding chromium on its own

@mhanberg
Copy link
Member

I'll try to see if we can make it work with chromium, but if it can't, then adding an option to disable is probably required.

@mhanberg mhanberg mentioned this issue Jul 15, 2022
Merged
@mhanberg
Copy link
Member

Released in v0.30.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(chromedriver): Account for Chromium when doing the version matching elixir-wallaby/wallaby
2 participants
@michallepicki @mhanberg