Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AbstractAdapter with AdapterInterface #12

Closed
garak opened this issue Dec 6, 2021 · 1 comment · Fixed by #14
Closed

Replace AbstractAdapter with AdapterInterface #12

garak opened this issue Dec 6, 2021 · 1 comment · Fixed by #14

Comments

@garak
Copy link
Contributor

garak commented Dec 6, 2021

The current implementation of Breaker class requires to inject \Symfony\Component\Cache\Adapter\AbstractAdapter.
I think it should type hint for more generic \Symfony\Component\Cache\Adapter\AdapterInterface, since the concrete object makes harder to use dependency injection (for example, with Symfony).

I can provide a PR.

@eljam
Copy link
Owner

eljam commented Dec 7, 2021

Yes good catch !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants